ci: wiki: Resolve some pylint warnings

Use resource management with urllib.request.urlopen, and move a print
out of an unnecessary "else" since the line before returns anyways.

Part-of: https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/6719
This commit is contained in:
Luca Weiss
2025-07-11 22:20:50 +02:00
committed by Oliver Smith
parent f94f17f188
commit 6f8ce18d96
+6 -4
View File
@@ -42,7 +42,8 @@ def get_wiki_devices_html(path):
else:
# Download wiki page
url = "http://wiki.postmarketos.org/wiki/Devices"
content = urllib.request.urlopen(url).read().decode("utf-8")
with urllib.request.urlopen(url) as f:
content = f.read().decode("utf-8")
# Split into booting and not booting
split = content.split("<span class=\"mw-headline\" id=\"Non-booting_devices\">")
@@ -57,7 +58,8 @@ def get_wiki_renamed_devices_html():
""":returns: HTML of the page"""
# Download wiki page
url = "http://wiki.postmarketos.org/wiki/Renamed_Devices"
return urllib.request.urlopen(url).read().decode("utf-8")
with urllib.request.urlopen(url) as f:
return f.read().decode("utf-8")
def check_device(device, html, is_booting):
@@ -126,8 +128,8 @@ def main():
print("wiki as well and make sure to add it here:")
print("https://postmarketos.org/renamed")
return 1
else:
print("*** Wiki check successful!")
print("*** Wiki check successful!")
return 0